rpuch commented on code in PR #7320:
URL: https://github.com/apache/ignite-3/pull/7320#discussion_r2653046085
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -685,6 +683,7 @@ grpId, hexLong(pageId)
if (waitUntilPageIsFullyInitialized) {
waitUntilPageIsFullyInitialized(resPointer);
}
+ metrics.recordPageAcquireTime(System.nanoTime() - startTime);
Review Comment:
```suggestion
}
metrics.recordPageAcquireTime(System.nanoTime() - startTime);
```
##########
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/replacement/AbstractPageReplacementTest.java:
##########
@@ -343,6 +362,28 @@ void
testFsyncDeltaFilesWillNotStartOnCheckpointUntilPageReplacementIsComplete()
verify(deltaFileIoFuture.join()).sync();
}
+ @Test
+ void verifyPageMemoryMetrics() throws Throwable {
+ testPageReplacement();
+
+ assertMetricValue(PAGES_READ, is(0L)); // since there is no existing
pages on disk
Review Comment:
```suggestion
assertMetricValue(PAGES_READ, is(0L)); // Since there are no
existing pages on disk.
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -829,6 +824,7 @@ grpId, hexLong(pageId)
headerIsValid(lockedPageAbsPtr, true);
}
}
+ metrics.recordPageAcquireTime(System.nanoTime() - startTime);
Review Comment:
```suggestion
}
metrics.recordPageAcquireTime(System.nanoTime() - startTime);
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -170,7 +170,7 @@ public class PersistentPageMemory implements PageMemory {
private final DirectMemoryProvider directMemoryProvider;
/** Segments array, {@code null} if not {@link #start() started}. */
- private volatile Segment @Nullable [] segments;
+ private volatile @Nullable Segment[] segments;
Review Comment:
Let's revert this change, see my other comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
