tkalkirill commented on code in PR #7330:
URL: https://github.com/apache/ignite-3/pull/7330#discussion_r2652823212
##########
modules/low-watermark/src/main/java/org/apache/ignite/internal/lowwatermark/LowWatermarkImpl.java:
##########
@@ -291,11 +295,19 @@ private void setLowWatermark(HybridTimestamp
newLowWatermark) {
lowWatermark = newLowWatermark;
}
- private void setLowWatermarkOnRecovery(@Nullable HybridTimestamp
newLowWatermark) {
+ @Override
+ public void listen(LowWatermarkEvent evt, EventListener<? extends
LowWatermarkEventParameters> listener) {
Review Comment:
Can we remove this method or am I missing something?
##########
modules/low-watermark/src/main/java/org/apache/ignite/internal/lowwatermark/LowWatermarkImpl.java:
##########
@@ -404,6 +416,10 @@ CompletableFuture<Void> updateAndNotify(HybridTimestamp
newLowWatermark) {
);
}
+ private void persistWatermark(HybridTimestamp newLowWatermark) {
Review Comment:
Technically, the vault could be in memory.
Can we rename it to "saveWatermark"?
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -1598,6 +1594,7 @@ CompletableFuture<Ignite> joinClusterAsync() {
lifecycleManager.startComponentsAsync(
componentContext,
catalogManager,
+ new LowWatermarkRectifier(lowWatermark,
catalogManager),
Review Comment:
I suggest moving it to a separate field, like other components, to keep the
code cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
