rpuch commented on code in PR #7330:
URL: https://github.com/apache/ignite-3/pull/7330#discussion_r2652952077
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -1598,6 +1594,7 @@ CompletableFuture<Ignite> joinClusterAsync() {
lifecycleManager.startComponentsAsync(
componentContext,
catalogManager,
+ new LowWatermarkRectifier(lowWatermark,
catalogManager),
Review Comment:
This component does not need to be referenced by anyone, so the field is not
required. And having it instantiated here allows the reader to see that this
component is a special (it's an ad-hoc solution for a specific problem, not a
component explicitly used by other components), so it makes sense to not create
a variable for it.
For these reasons, I would prefer to leave it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
