ivanzlenko commented on code in PR #7374:
URL: https://github.com/apache/ignite-3/pull/7374#discussion_r2675676343
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryDataRegion.java:
##########
@@ -192,4 +184,26 @@ private void checkDataRegionStarted() {
throw new StorageException("Data region not started");
}
}
+
+ @Override
+ public long regionSize() {
+ return maxSize(cfg);
+ }
+
+ private static long maxSize(VolatilePageMemoryProfileConfiguration cfg) {
+ var cfgView = (VolatilePageMemoryProfileView) cfg.value();
+
+ long maxSize = cfgView.maxSizeBytes();
+
+ if (maxSize == UNSPECIFIED_SIZE) {
+ maxSize = StorageEngine.defaultDataRegionSize();
+
+ LOG.info(
Review Comment:
This place is reverted so it will not be a problem, since we will log it
once.
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryStorageEngine.java:
##########
@@ -389,6 +389,13 @@ private void
addDataRegion(PersistentPageMemoryProfileConfiguration storageProfi
regions.put(storageProfileConfiguration.name().value(), dataRegion);
}
+ @Override
+ public long requiredOffHeapMemorySize() {
Review Comment:
This place is reverted so it will not be a problem, since we will log it
once.
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryStorageEngine.java:
##########
@@ -188,6 +188,13 @@ public void destroyMvTable(int tableId) {
// No-op.
}
+ @Override
+ public long requiredOffHeapMemorySize() {
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
