tkalkirill commented on code in PR #7374:
URL: https://github.com/apache/ignite-3/pull/7374#discussion_r2676236195
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryDataRegion.java:
##########
@@ -54,6 +54,8 @@ public class VolatilePageMemoryDataRegion implements
DataRegion<VolatilePageMemo
private final VolatilePageMemoryProfileConfiguration cfg;
+ private volatile VolatileDataRegionConfiguration regionConfiguration;
Review Comment:
This is not necessary for now, a regular `long` field will be sufficient.
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/DataRegion.java:
##########
@@ -25,4 +25,9 @@ public interface DataRegion<T extends PageMemory> {
* Returns page memory.
*/
T pageMemory();
+
+ /**
+ * Returns the region size in bytes.
+ */
+ long regionSize();
Review Comment:
Why not get rid of it if `PersistentPageMemoryStorageEngine` and
`VolatilePageMemoryStorageEngine` clearly use
`PersistentPageMemoryDataRegion::regionSize` and
`VolatilePageMemoryDataRegion::regionSize` not `DataRegion::regionSize`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
