arcolight commented on code in PR #7300:
URL: https://github.com/apache/ignite-3/pull/7300#discussion_r2694941782
##########
modules/platforms/cpp/ignite/client/CMakeLists.txt:
##########
@@ -113,16 +115,35 @@ foreach(_target_lib IN LISTS _target_libs)
set_target_properties(${_target_lib} PROPERTIES OUTPUT_NAME
${PROJECT_NAME})
endif()
- target_link_libraries(${_target_lib} ${LIBRARIES})
+ target_link_libraries(${_target_lib}
+ PRIVATE ignite-tuple ignite-network ignite-protocol
uni-algo::uni-algo
+ INTERFACE ignite-common)
endforeach()
unset(_target_libs)
+add_library(ignite::client ALIAS ${TARGET})
+add_library(ignite::client-static ALIAS ${TARGET}-static)
+
if (${INSTALL_IGNITE_FILES})
- install(TARGETS ${TARGET}
- RUNTIME DESTINATION bin
- ARCHIVE DESTINATION lib
- LIBRARY DESTINATION lib
+ get_target_property(IGNITE_CLIENT_INCLUDES ${TARGET} INCLUDE_DIRECTORIES)
+ install(TARGETS ${TARGET} ignite-common tfpsacrypto
+ EXPORT ignite-client-targets
+ RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
+ ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
+ LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+ INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
+ )
Review Comment:
Fixed, libraries removed from the export set and install targets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
