arcolight commented on code in PR #7300:
URL: https://github.com/apache/ignite-3/pull/7300#discussion_r2694967165
##########
modules/platforms/cpp/tests/fake_server/CMakeLists.txt:
##########
@@ -23,7 +23,7 @@ set(SOURCES
main.cpp
fake_server.cpp
tcp_client_channel.cpp
- connection_test.cpp
+ connection_test.cpp
)
-ignite_test(${TARGET} SOURCES ${SOURCES} LIBS ignite-test-common
ignite3-client)
\ No newline at end of file
+ignite_test(${TARGET} SOURCES ${SOURCES} LIBS ignite-test-common
ignite3-client msgpack-c)
Review Comment:
No, msgpack is explicit dependency and we don't nee find_package here, it is
redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]