nizhikov commented on code in PR #12642:
URL: https://github.com/apache/ignite/pull/12642#discussion_r2720320706
##########
modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java:
##########
@@ -1653,6 +1655,11 @@ private void addDataStorageConfigurationAttributes()
throws IgniteCheckedExcepti
// Save data storage configuration.
add(ATTR_DATA_STORAGE_CONFIG,
ctx.marshallerContext().jdkMarshaller().marshal(cfg.getDataStorageConfiguration()));
+
+ DataStorageConfiguration dsCfg = cfg.getDataStorageConfiguration();
+
+ ctx.addNodeAttribute(ATTR_WAL_MODE,
+ dsCfg != null ? dsCfg.getWalMode().ordinal() :
DataStorageConfiguration.DFLT_WAL_MODE.ordinal());
Review Comment:
Why do we want to use `DFLT_WAL_MODE` when dsCfg is null?
We don't want to send untrue values to the other nodes.
Let's use `null` value if possible or don't set WAL attribute if dsCfg is
null and handle it on receiver side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
