nizhikov commented on code in PR #12642:
URL: https://github.com/apache/ignite/pull/12642#discussion_r2803804801
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java:
##########
@@ -2173,6 +2186,28 @@ private DiscoCache resolveDiscoCache(int grpId,
AffinityTopologyVersion topVer)
return cache;
}
+ /**
+ * Extracts WAL mode from marshalled Data Storage Configuration of Cluster
node
+ * @param n Cluster node
+ * @return WAL mode stored in dsCfg or {@code null} if unmarshalling
failed or got null dsCfg
+ */
+ private WALMode nodeWalMode(ClusterNode n) {
+ Object dsCfgBytes =
n.attribute(IgniteNodeAttributes.ATTR_DATA_STORAGE_CONFIG);
Review Comment:
There are several places to turn attribute into `DataStorageConfiguration`
instance. Let's extract some method and use it everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
