sergey-chugunov-1985 commented on code in PR #12517:
URL: https://github.com/apache/ignite/pull/12517#discussion_r2721489255
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -2733,42 +2699,15 @@ private static class PendingMessages implements
Iterable<TcpDiscoveryAbstractMes
*/
void add(TcpDiscoveryAbstractMessage msg) {
msgs.add(new PendingMessage(msg));
-
- while (msgs.size() > MAX) {
Review Comment:
As far as I can see, the old implementation have this logic to maintain
internal queue size and not let it get close to MAX * 2 size right on add
operation.
Now there is no such logic, we clean up internal collection on discard call
itself.
Do we understand the logic behing this old behavior? What are situations
when this logic starts working? Does new implementation perform better or worse
in these situations?
This whole discard logic looks very important to me, and I want to make sure
that this change doesn't break some corner case with lagging network which is
not covered with our test base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
