anton-vinogradov commented on code in PR #12517:
URL: https://github.com/apache/ignite/pull/12517#discussion_r2721527647
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -2733,42 +2699,15 @@ private static class PendingMessages implements
Iterable<TcpDiscoveryAbstractMes
*/
void add(TcpDiscoveryAbstractMessage msg) {
msgs.add(new PendingMessage(msg));
-
- while (msgs.size() > MAX) {
Review Comment:
Old sollution (queue limiting) seems to be a buggy. In case of a queue
overfill we just lose the consistency.
New solution guarantee the consistency and cleans the elements only when
it's safe to clean.
Not sure we have deployments for 1K+ nodes where this will NOT happen now,
but code becomes more stable, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
