sashapolo commented on code in PR #7527:
URL: https://github.com/apache/ignite-3/pull/7527#discussion_r2759437954
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java:
##########
@@ -1196,14 +1197,31 @@ public List<RowMeta> rowsStartingWith(RowId
lowerBoundInclusive, RowId upperBoun
int commitZoneId = transactionState.getInt();
int commitPartitionId =
Short.toUnsignedInt(transactionState.getShort());
- row = new RowMeta(rowId, txId, commitZoneId,
commitPartitionId);
+ HybridTimestamp newestCommitTimestamp = null;
+
+ it.next();
+
+ ByteBuffer dataIdKey =
DIRECT_DATA_ID_KEY_BUFFER.get().clear();
+
+ int keyLen = it.key(dataIdKey);
+
+ dataIdKey.position(0).limit(keyLen);
+
+ if (matches(rowId, dataIdKey)) {
+ newestCommitTimestamp =
readTimestampDesc(dataIdKey);
+ }
Review Comment:
```suggestion
HybridTimestamp newestCommitTimestamp =
matches(rowId, dataIdKey) ? readTimestampDesc(dataIdKey) : null;
```
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java:
##########
@@ -1196,14 +1197,31 @@ public List<RowMeta> rowsStartingWith(RowId
lowerBoundInclusive, RowId upperBoun
int commitZoneId = transactionState.getInt();
int commitPartitionId =
Short.toUnsignedInt(transactionState.getShort());
- row = new RowMeta(rowId, txId, commitZoneId,
commitPartitionId);
+ HybridTimestamp newestCommitTimestamp = null;
+
+ it.next();
Review Comment:
Please leave a comment here, like `Continue searching through committed
versions to extract the most recent commit timestamp`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
