tkalkirill commented on code in PR #12743:
URL: https://github.com/apache/ignite/pull/12743#discussion_r2814879174
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/UserDefinedFunctionsIntegrationTest.java:
##########
@@ -105,18 +105,25 @@ public void testSystemFunctionOverriding() throws
Exception {
// Make sure that the new functions didn't affect schema 'PUBLIC'.
assertQuery("SELECT
UPPER(?)").withParams("abc").returns("ABC").check();
- assertQuery("select UNIX_SECONDS(TIMESTAMP '2021-01-01
00:00:00')").returns(1609459200L).check();
- assertQuery("select * from table(SYSTEM_RANGE(1,
2))").returns(1L).returns(2L).check();
- assertQuery("select
TYPEOF(?)").withParams(1L).returns("BIGINT").check();
- assertQuery("select ? + ?").withParams(1, 2).returns(3).check();
- assertThrows("select PLUS(?, ?)", SqlValidatorException.class, "No
match found for function signature", 1, 2);
+ assertQuery("SELECT UNIX_SECONDS(TIMESTAMP '2021-01-01
00:00:00')").returns(1609459200L).check();
Review Comment:
I don't think these changes are necessary to this ticket, it's at your
discretion, of course.
##########
modules/core/src/test/java/org/apache/ignite/testframework/GridTestUtils.java:
##########
@@ -2639,6 +2640,15 @@ public static long sleep_and_can_fail(long sleepMs,
boolean fail) {
return sleep;
}
+
+ /** Function consume String array and output it row by row. */
+ @QuerySqlTableFunction(alias = "STR_ARRAY_CONSUME_TABLE", columnTypes
= {String.class}, columnNames = {"RESULT"})
+ public static Iterable<Object[]> strArrConsumeTable(List<String>
array) {
Review Comment:
I wouldn't put this code into utilities, it doesn't look like a utility, but
rather like a test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
