tkalkirill commented on code in PR #12743:
URL: https://github.com/apache/ignite/pull/12743#discussion_r2815360155
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/UserDefinedFunctionsIntegrationTest.java:
##########
@@ -105,18 +105,25 @@ public void testSystemFunctionOverriding() throws
Exception {
// Make sure that the new functions didn't affect schema 'PUBLIC'.
assertQuery("SELECT
UPPER(?)").withParams("abc").returns("ABC").check();
- assertQuery("select UNIX_SECONDS(TIMESTAMP '2021-01-01
00:00:00')").returns(1609459200L).check();
- assertQuery("select * from table(SYSTEM_RANGE(1,
2))").returns(1L).returns(2L).check();
- assertQuery("select
TYPEOF(?)").withParams(1L).returns("BIGINT").check();
- assertQuery("select ? + ?").withParams(1, 2).returns(3).check();
- assertThrows("select PLUS(?, ?)", SqlValidatorException.class, "No
match found for function signature", 1, 2);
+ assertQuery("SELECT UNIX_SECONDS(TIMESTAMP '2021-01-01
00:00:00')").returns(1609459200L).check();
Review Comment:
In my opinion, these changes are redundant within the scope of the
documentation ticket and are not related to this issue.
From my experience, when looking at the diff, it's better to see the ticket
where the change occurred and made sense, rather than having to delve into an
unrelated PR and look through everything there to figure it out.
In my opinion, it's better not to do this in this ticket.
Refactoring and other issues should be a separate ticket.
I'm not insisting it's up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
