rpuch commented on code in PR #7598:
URL: https://github.com/apache/ignite-3/pull/7598#discussion_r2817138740
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -1743,16 +1745,21 @@ private void executeApplyingTasks(final
List<LogEntryAndClosure> tasks) {
}
continue;
}
+
+ // To prevent safe timestamp values from becoming stale, we
must assign them under a valid leader lock.
+ safeTs = tryAssignSafeTimestamp(task, safeTs);
+
+ if (rejectCommandIfSafeTimeIsNotAcceptable(safeTs, task)) {
Review Comment:
Please don't confuse ActionRequest (which brings a command to Raft group via
its leader) and AppendEntriesRequest (which replicates N commands from the
leader to other members of the group). Here, it's about ActionRequest only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
