rpuch commented on code in PR #7598:
URL: https://github.com/apache/ignite-3/pull/7598#discussion_r2821470296
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -1788,6 +1795,31 @@ private void executeApplyingTasks(final
List<LogEntryAndClosure> tasks) {
return safeTs;
}
+ private boolean rejectCommandIfSafeTimeIsNotAcceptable(@Nullable
HybridTimestamp safeTs, LogEntryAndClosure task) {
Review Comment:
What you suggested implies there are no side effects, but there are, and
they are a lot more important than returning the 'whether we should not
replicate the command'; that's why I think it's better to call it
'reject...If...' to highlight that we are mostly interested in the side effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
