maksaska commented on code in PR #12913:
URL: https://github.com/apache/ignite/pull/12913#discussion_r3246886711
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotHandlerTest.java:
##########
@@ -142,11 +142,13 @@ public void testClusterSnapshotHandlers() throws
Exception {
IgniteFuture<Void> fut =
ignite.snapshot().restoreSnapshot(SNAPSHOT_NAME, null);
- GridTestUtils.assertThrowsAnyCause(log, () -> fut.get(TIMEOUT),
IgniteCheckedException.class, expMsg);
+ runWithLogggedThreadDump(() ->
+ GridTestUtils.assertThrowsAnyCause(log, () -> fut.get(TIMEOUT),
IgniteCheckedException.class, expMsg));
Review Comment:
This one coming from AbstractSnapshotSelfTest which is 15sec. I see you had
only 1 run for Disk Page Compressions 5 which might not be enough. The timeout
is not changed so I anticipate further failures. The ticket is for Disk 4, and
the test fails on Disk 5, we should either fix Disk 5 as well and add it to the
ticket description or remove this change.
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotRestoreWithIndexingTest.java:
##########
@@ -74,7 +74,8 @@ public void testBasicClusterSnapshotRestore() throws
Exception {
IgniteEx client = startGridsWithSnapshot(2, CACHE_KEYS_RANGE, true);
- grid(0).snapshot().restoreSnapshot(SNAPSHOT_NAME,
Collections.singleton(DEFAULT_CACHE_NAME)).get(TIMEOUT);
+ runWithLogggedThreadDump(() ->
+ grid(0).snapshot().restoreSnapshot(SNAPSHOT_NAME,
Collections.singleton(DEFAULT_CACHE_NAME)).get(TIMEOUT));
Review Comment:
This one coming from AbstractSnapshotSelfTest which is 15sec. I see you had
only 1 run for Disk Page Compressions 6 which might not be enough. The timeout
is not changed so I anticipate further failures. The ticket is for Disk 4, and
the test fails on Disk 6, we should either fix Disk 6 as well and add it to the
ticket description or remove this change.
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotHandlerTest.java:
##########
@@ -142,11 +142,13 @@ public void testClusterSnapshotHandlers() throws
Exception {
IgniteFuture<Void> fut =
ignite.snapshot().restoreSnapshot(SNAPSHOT_NAME, null);
- GridTestUtils.assertThrowsAnyCause(log, () -> fut.get(TIMEOUT),
IgniteCheckedException.class, expMsg);
+ runWithLogggedThreadDump(() ->
+ GridTestUtils.assertThrowsAnyCause(log, () -> fut.get(TIMEOUT),
IgniteCheckedException.class, expMsg));
changeMetadataRequestIdOnDisk(reqIdRef.get());
- ignite.snapshot().restoreSnapshot(SNAPSHOT_NAME, null).get(TIMEOUT);
+ runWithLogggedThreadDump(() ->
+ ignite.snapshot().restoreSnapshot(SNAPSHOT_NAME,
null).get(TIMEOUT));
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
