maksaska commented on code in PR #12913:
URL: https://github.com/apache/ignite/pull/12913#discussion_r3259151052
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotCheckWithIndexesTest.java:
##########
@@ -36,6 +36,9 @@
* Cluster-wide snapshot test check command with indexes.
*/
public class IgniteClusterSnapshotCheckWithIndexesTest extends
AbstractSnapshotSelfTest {
+ /** Timeout in milliseconds to await for snapshot operation being
completed. */
+ protected static final long TIMEOUT = 60_000;
Review Comment:
Same question as for IgniteClusterSnapshotHandlerTest.
The ticket description mentions covering only Disk 4 tests, but this PR
modifies IgniteClusterSnapshotCheckWithIndexingTest as well as
IgniteClusterSnapshotRestoreWithIndexingTest, which belongs to the Disk 6 suite.
- If we are including Disk 6: Please update the ticket description to avoid
confusion. Also, can we update the timeouts for
IgniteClusterSnapshotMetricsTest while we are at it? And I see
IgniteClusterSnapshotRestoreWithIndexingTest timeouts unchanged. Was it on
purpuse?
- If Disk 6 is out of scope: I suggest reverting the changes to keep this PR
focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
