chesnokoff commented on code in PR #13136:
URL: https://github.com/apache/ignite/pull/13136#discussion_r3287022967
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TxDeadlockDetection.java:
##########
@@ -55,7 +56,7 @@ public class TxDeadlockDetection {
public static final int DFLT_TX_DEADLOCK_DETECTION_TIMEOUT = 60000;
/** Deadlock detection maximum iterations. */
- private static int deadLockTimeout =
+ private static final int DEAD_LOCK_TIMEOUT =
Review Comment:
My position is not really about final/non-final definition itself. My point
is that it is usually safer to keep PRs as minimal as possible for a specific
purpose. The main goal here is to fix `TxDeadlockCauseTest`, and for now it is
not very clear why we also need to refactor an unrelated field and affect
existing test behavior.
Green TC runs are definitely a good sign, but some flaky tests fail once in
weeks or even months. That's why I'd prefer to avoid introducing additional
assumptions here unless this change is really required for the fix itself.
Could you provide more reasoning on why it is safe to remove
before/afterTests from `TxDeadlockDetectionNoHangsTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
