chesnokoff commented on code in PR #13136:
URL: https://github.com/apache/ignite/pull/13136#discussion_r3306577166


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transactions/TxDeadlockDetectionNoHangsTest.java:
##########
@@ -68,6 +74,9 @@ public class TxDeadlockDetectionNoHangsTest extends 
GridCommonAbstractTest {
 
         cfg.setCacheConfiguration(ccfg);
 
+        listeningLog.registerListener(lsnr);

Review Comment:
   ```
   public void registerListener(@NotNull LogListener lsnr) {
           lsnr.reset();
   
   ```
   
   Can we lose an already caught "Deadlock detection was timed out" message 
here? `doTest` starts `grid(NODES_CNT)` many times and each start calls 
`getConfiguration()`. But `registerListener(LogListener)` resets the listener, 
so a later node start can clear a timeout message that was caught before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to