anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3579093808
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/IgniteIoTestMessage.java:
##########
@@ -241,8 +239,8 @@ public long responseReceivedTsMillis() {
}
/**
- * This method is called to initialize tracing variables.
- * TODO: introduce direct message lifecycle API?
+ * Captures the receive timestamp. Invoked by {@code GridIoManager} right
after the message is received,
Review Comment:
Fixed — "received" (and "sent" in the sibling method).
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/IgniteIoTestMessage.java:
##########
@@ -241,8 +239,8 @@ public long responseReceivedTsMillis() {
}
/**
- * This method is called to initialize tracing variables.
- * TODO: introduce direct message lifecycle API?
+ * Captures the receive timestamp. Invoked by {@code GridIoManager} right
after the message is received,
Review Comment:
Removed — kept only the caller-independent part: repeated calls are no-ops.
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/IgniteIoTestMessage.java:
##########
@@ -259,8 +257,8 @@ public void onAfterRead() {
}
/**
- * This method is called to initialize tracing variables.
- * TODO: introduce direct message lifecycle API?
+ * Captures the send timestamp. Invoked by {@code GridIoManager} right
before the message is sent,
Review Comment:
Removed here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
