anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3579264467
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicUpdateRequest.java:
##########
@@ -98,14 +100,14 @@ public class GridDhtAtomicUpdateRequest extends
GridDhtAtomicAbstractUpdateReque
boolean forceTransformBackups;
/** Entry processors. */
- private List<EntryProcessor<Object, Object, Object>> entryProcessors;
+ List<EntryProcessor<Object, Object, Object>> entryProcessors;
Review Comment:
Right — leftover from an intermediate codegen approach; in the final design
the conversion lives in the class's own hand-written `marshal`/`unmarshal`
hooks and the generated companions never touch these fields. Restored `private`
(all three occurrences).
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridDhtAtomicUpdateRequest.java:
##########
@@ -98,14 +100,14 @@ public class GridDhtAtomicUpdateRequest extends
GridDhtAtomicAbstractUpdateReque
boolean forceTransformBackups;
/** Entry processors. */
- private List<EntryProcessor<Object, Object, Object>> entryProcessors;
+ List<EntryProcessor<Object, Object, Object>> entryProcessors;
/** Entry processors bytes. */
@Order(12)
List<byte[]> entryProcessorsBytes;
/** Near entry processors. */
- private List<EntryProcessor<Object, Object, Object>> nearEntryProcessors;
+ List<EntryProcessor<Object, Object, Object>> nearEntryProcessors;
Review Comment:
Restored `private`.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/atomic/GridNearAtomicFullUpdateRequest.java:
##########
@@ -62,7 +65,7 @@ public class GridNearAtomicFullUpdateRequest extends
GridNearAtomicAbstractUpdat
List<CacheObject> vals;
/** Entry processors. */
- private List<EntryProcessor<Object, Object, Object>> entryProcessors;
+ List<EntryProcessor<Object, Object, Object>> entryProcessors;
Review Comment:
Restored `private`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]