anton-vinogradov commented on code in PR #13095: URL: https://github.com/apache/ignite/pull/13095#discussion_r3588672613
########## modules/core/src/main/java/org/apache/ignite/plugin/extensions/communication/MessageMarshaller.java: ########## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.plugin.extensions.communication; + +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.internal.GridKernalContext; +import org.apache.ignite.internal.managers.communication.IgniteMessageFactory; +import org.apache.ignite.internal.managers.communication.MessageUnmarshalDedup; +import org.apache.ignite.internal.processors.cache.CacheObjectContext; +import org.apache.ignite.internal.util.typedef.internal.U; +import org.jetbrains.annotations.Nullable; + +/** + * Handles {@code marshal}/{@code unmarshal} for a {@link Message} type that requires custom serialization. + * + * @param <M> Message type. + */ +public interface MessageMarshaller<M extends Message> { + /** + * Marshals the message on the user thread before sending. + * + * @param msg Message to marshal. Review Comment: Digging into the grammar rather than the counts: the base verb is `marshal` (single-L) in **both** AmE and BrE — dictionaries list `marshal, verb`. British English doubles the L only in the **inflected** forms (`marshalled`, `marshalling`) and the agent noun (`marshaller`), never in the base verb itself. So the codebase being British-spelled is exactly why the current split is correct: the class is `MessageMarshaller` and the prose says "marshalling" (both double-L — agent noun and gerund), while the **method** is the base verb `marshal()`/`unmarshal()` (single-L). Renaming the method to `marshall()` would be a misspelling — `marshall` as a bare verb isn't a word in either dialect (it's the surname, or an inflected form missing its ending). Happy to align anything that's genuinely inconsistent, but the method verbs are already the correct spelling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
