anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3588885607
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/TxEntryValueHolder.java:
##########
@@ -119,25 +116,6 @@ public boolean hasReadValue() {
return hasReadVal;
}
- /**
- * @param ctx Cache context.
- * @throws IgniteCheckedException If marshaling failed.
- */
- public void marshal(GridCacheContext<?, ?> ctx) throws
IgniteCheckedException {
- if (hasWriteVal && val != null)
- val.prepareMarshal(ctx.cacheObjectContext());
- }
-
- /**
- * @param ctx Cache context.
- * @param ldr Class loader.
- * @throws IgniteCheckedException If unmarshalling failed.
- */
- public void unmarshal(CacheObjectValueContext ctx, ClassLoader ldr) throws
IgniteCheckedException {
- if (hasWriteVal && val != null)
Review Comment:
No — dropping `@Order` would lose behaviour. `hasWriteVal` is read on the
**receiver**: `GridDhtTxLocalAdapter.addEntry` (processing an incoming DHT
tx-prepare) merges via `existing.value(e.value(), e.hasWriteValue(),
e.hasReadValue())`, so the unmarshalled flag drives whether the value is
applied as a write. It's only partially derivable — the setter forces it `true`
for `CREATE`/`UPDATE`/`DELETE` (and `op` is on the wire), so those survive, but
a non-CUD op carrying a write value — a `TRANSFORM` (entry-processor invoke) —
carries its own bit that `op` doesn't imply; without the wire field its result
wouldn't be applied as a write on the receiver. Master serializes it too
(`@Order(2)`). My earlier "dead" remark was narrower: the *gate on
`hasWriteVal` inside the removed marshal hook* was inert (`CacheObject.marshal`
is self-guarded) — the field itself is live wire state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
