tkalkirill commented on code in PR #13311:
URL: https://github.com/apache/ignite/pull/13311#discussion_r3711571069
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgniteSqlValidator.java:
##########
@@ -84,9 +87,6 @@
/** Validator. */
@Value.Enclosing
public class IgniteSqlValidator extends SqlValidatorImpl {
Review Comment:
> this issue is an adoption of related
[ignite-3](https://issues.apache.org/jira/browse/IGNITE-3) issue###
Which issue are you referring to?
> let`s move sequentially here and implement it during different activity
Why? In this ticket, you're checking how it handles BigDecimal, and it’s not
obvious to me how it will behave with floating-point numbers.
> Rounding policy need to work equal for aggregates avg too
Rounding within a set of values is one thing, while rounding during
calculations is another. That is precisely why the interface is named
`FetchOffsetRoundingPolicy` to avoid conflating the two types of logic.
> need additional tests and check that it work the same as in common DB`s
As a Calcite ticket investigation revealed, different DBMSs handle
floating-point numbers differently for FETCH, OFFSET, and LIMIT. That is why
this interface was introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
