zstan commented on code in PR #13311:
URL: https://github.com/apache/ignite/pull/13311#discussion_r3712797041
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java:
##########
@@ -1050,4 +1054,33 @@ private ScanStorageNode<Row> createStorageScan(
otherColMapping
);
}
+
+ /** */
+ private long validateAndGetFetchOffsetParams(RexNode node, String op) {
Review Comment:
I miss you idea here too:
```
long offset = rel.offset() == null ? 0 :
validateAndGetFetchOffsetParams(rel.offset(), "offset");
long fetch = rel.fetch() == null ? -1 :
validateAndGetFetchOffsetParams(rel.fetch(), "fetch");
```
you suggest to handle null check logic into 2 different func which are call
3rd common validation ? I didn\`t see any simplification here ((
```
rel.offset() == null ? 0
rel.fetch() == null ? -1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
