tkalkirill commented on code in PR #13375:
URL: https://github.com/apache/ignite/pull/13375#discussion_r3734037920
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgniteSqlValidator.java:
##########
@@ -262,36 +265,39 @@ private void validateFetchOffset(@Nullable SqlNode n,
String clauseName) {
checkLimitOffset(offsetFetchLimit, n, clauseName);
}
else if (n instanceof SqlDynamicParam dynamicParam) {
- // Dynamic parameters are nullable.
- RelDataType expectType =
typeFactory.createTypeWithNullability(typeFactory.createSqlType(SqlTypeName.DECIMAL),
true);
-
if (definedDynParam(dynamicParam)) {
Object param = parameters[dynamicParam.getIndex()];
if (!(param instanceof Number)) {
Resources.ExInst<SqlValidatorException> err;
if (param == null)
- err =
IgniteResource.INSTANCE.incorrectDynamicParameterType(SqlTypeName.BIGINT.toString(),
"null");
+ err =
IgniteResource.INSTANCE.incorrectDynamicParameterType(SqlTypeName.DECIMAL.toString(),
"null");
else {
SqlTypeName paramType =
typeFactory().createType(param.getClass()).getSqlTypeName();
- err =
IgniteResource.INSTANCE.incorrectDynamicParameterType(SqlTypeName.BIGINT.toString(),
paramType.getName());
+ err =
IgniteResource.INSTANCE.incorrectDynamicParameterType(SqlTypeName.DECIMAL.toString(),
paramType.getName());
Review Comment:
I got rid of that.
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementor.java:
##########
@@ -571,7 +576,7 @@ private boolean hasExchange(RelNode rel) {
ctx,
rowType,
idxBndRel.first() ? cmp : cmp.reversed(),
- 0,
+ SortNode.OFFSET_DEFAULT,
Review Comment:
I got rid of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
