zstan commented on code in PR #13375:
URL: https://github.com/apache/ignite/pull/13375#discussion_r3734891030
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java:
##########
@@ -973,49 +971,49 @@ public void testCastDecimalOverflows() {
// BIGINT
assertQuery("SELECT CAST(9223372036854775807.1 AS
BIGINT)").returns(9223372036854775807L).check();
assertQuery("SELECT CAST(9223372036854775807.4 AS
BIGINT)").returns(9223372036854775807L).check();
- assertQuery("SELECT CAST(9223372036854775806.9 AS
BIGINT)").returns(9223372036854775807L).check();
- assertThrows("SELECT CAST(9223372036854775807.5 AS BIGINT)",
IgniteSQLException.class, "BIGINT overflow");
- assertThrows("SELECT CAST(9223372036854775807.9 AS BIGINT)",
IgniteSQLException.class, "BIGINT overflow");
- assertQuery("SELECT CAST(9223372036854775807.9 - 1 AS
BIGINT)").returns(9223372036854775807L).check();
+ assertQuery("SELECT CAST(9223372036854775806.9 AS
BIGINT)").returns(9223372036854775806L).check();
Review Comment:
with such approach seems we miss huge number of corner-case tests i.e.
now we need to check :
assertThrows("SELECT CAST(922337203685477580[8].5 AS BIGINT)",
IgniteSQLException.class, "BIGINT overflow");
and all below, wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
