tkalkirill commented on code in PR #13467:
URL: https://github.com/apache/ignite/pull/13467#discussion_r3824268182
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/LimitOffsetPlannerTest.java:
##########
@@ -88,7 +91,18 @@ public void testFetchExpressionPushDown() throws Exception {
.and(sort -> sort.fetch != null))))));
assertPlan("SELECT * FROM TEST ORDER BY ID OFFSET 1 ROWS "
- + "FETCH FIRST (ABS(0.5)) ROWS ONLY", publicSchema,
+ + "FETCH FIRST (ABS(0.6)) ROWS ONLY", publicSchema,
+ isInstanceOf(IgniteLimit.class)
+ .and(limit -> limit.offset() != null && limit.fetch() != null)
+ .and(input(isInstanceOf(IgniteExchange.class)
+ .and(input(isInstanceOf(IgniteSort.class)
+ .and(sort -> sort.offset != null && sort.fetch !=
null))))));
+
+ assertPlan(contextBuilder()
Review Comment:
Yes. The integration test only verifies the query result, while this test
verifies that the custom pagination policy reaches `SortConverterRule` and
affects limit push-down. Without this assertion, the outer `IgniteLimit` may
preserve correctness while the plan silently falls back to an unbounded sort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
