alex-plekhanov commented on code in PR #13467:
URL: https://github.com/apache/ignite/pull/13467#discussion_r3822807157
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/AbstractPlannerTest.java:
##########
@@ -229,10 +230,13 @@ private PlanningContext plannerCtx(
Collection<IgniteSchema> schemas,
@Nullable RelOptListener planLsnr,
Collection<Object> params,
- Collection<String> disabledRules
+ Collection<String> disabledRules,
+ @Nullable Context additionalCtx
) {
+ Context parentCtx = Contexts.of(baseQueryContext(schemas), planLsnr);
Review Comment:
Contexts.of(baseQueryContext(schemas), planLsnr, additionalCtx);
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/LimitOffsetPlannerTest.java:
##########
@@ -88,7 +91,18 @@ public void testFetchExpressionPushDown() throws Exception {
.and(sort -> sort.fetch != null))))));
assertPlan("SELECT * FROM TEST ORDER BY ID OFFSET 1 ROWS "
- + "FETCH FIRST (ABS(0.5)) ROWS ONLY", publicSchema,
+ + "FETCH FIRST (ABS(0.6)) ROWS ONLY", publicSchema,
+ isInstanceOf(IgniteLimit.class)
+ .and(limit -> limit.offset() != null && limit.fetch() != null)
+ .and(input(isInstanceOf(IgniteExchange.class)
+ .and(input(isInstanceOf(IgniteSort.class)
+ .and(sort -> sort.offset != null && sort.fetch !=
null))))));
+
+ assertPlan(contextBuilder()
Review Comment:
Do we really need this test if it only affects extensions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
