Copilot commented on code in PR #13226:
URL: https://github.com/apache/ignite/pull/13226#discussion_r3958033403
##########
modules/ducktests/tests/ignitetest/utils/ignite_test.py:
##########
@@ -32,7 +32,7 @@
class IgniteTestContext(TestContext):
def __init__(self, test_context):
- super().__init__()
+ super().__init__(**test_context.__dict__)
self.__dict__.update(**test_context.__dict__)
Review Comment:
`super().__init__(**test_context.__dict__)` will raise `TypeError` if
`test_context.__dict__` contains keys that `TestContext.__init__` doesn’t
accept. Consider either (a) reverting to `super().__init__()` and only copying
attributes, or (b) filtering the kwargs to only parameters accepted by
`TestContext.__init__` before splatting. Also, the subsequent
`self.__dict__.update(...)` can overwrite values initialized by `TestContext`
(including any normalization it performs), so it should be removed or changed
to only set missing attributes.
##########
modules/ducktests/tests/docker/run_tests.sh:
##########
@@ -138,7 +149,7 @@ done
if [ -z "$IMAGE_NAME" ]; then
IMAGE_NAME="$IMAGE_PREFIX-$JDK_VERSION"
Review Comment:
The image tag default (`$IMAGE_PREFIX-$JDK_VERSION`) does not incorporate
`PYTHON_VERSION`, but the build output differs based on `-p`. If a user builds
with different Python versions, they’ll overwrite/reuse the same tag, which can
lead to running tests on an unexpected Python runtime. Include Python (and
ideally also the no-cache choice doesn’t matter) in the default image name
(e.g., suffix with `-py$PYTHON_VERSION`) or otherwise ensure unique tagging per
Python version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
