Copilot commented on code in PR #13226:
URL: https://github.com/apache/ignite/pull/13226#discussion_r3964879003
##########
modules/ducktests/tests/docker/ducker-ignite:
##########
@@ -63,15 +66,19 @@ Usage: ${script_path} [command] [options]
help|-h|--help
Display this help message
-build [-j|--jdk JDK] [-p|--python PYTHON_VERSION] [-c|--context] [image-name]
+build [-j|--jdk JDK] [-p|--python PYTHON_VERSION] [--no-cache] [-c|--context]
[image-name]
Build a docker image that represents ducker node. Image is tagged with
specified ${image_name}.
+ If the image name is omitted, it defaults to
${default_image_name}-<jdk>-py<python-version>,
+ so that images built with different JDK or Python versions do not
overwrite each other.
Review Comment:
The help text references `${image_name}`, but that variable isn’t set when
printing `usage()`, so the output will be empty/misleading (e.g., "tagged with
specified "). Use plain wording (or a placeholder like `<image-name>`) instead
of expanding an undefined variable.
##########
modules/ducktests/tests/docker/ducker-ignite:
##########
@@ -288,14 +301,16 @@ ducker_build() {
case "${1}" in
-j|--jdk) set_once jdk_version "${2}" "the OpenJDK base image";
shift 2;;
-p|--python) set_once python_version "${2}" "the Python version";
shift 2;;
+ --no-cache) set_once no_cache "true"; shift;;
-c|--context) docker_context="${2}"; shift 2;;
Review Comment:
`set_once` expects a human-readable description as its 3rd argument for
error messages; the `--no-cache` case omits it. If the flag is provided more
than once, the script will error with an unhelpful message ("more than one
value specified for "). Pass a description string for consistency with other
options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
