nizhikov commented on code in PR #13668:
URL: https://github.com/apache/ignite/pull/13668#discussion_r4244582633
##########
modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinConnection.java:
##########
@@ -472,12 +472,14 @@ void executeNative(String sql, SqlCommand cmd,
JdbcThinStatement stmt) throws SQ
+ cliIo.igniteVersion() + ']', INTERNAL_ERROR);
}
- streamState = new StreamState((SqlSetStreamingCommand)cmd,
cliIo);
+ StreamState streamState0 = new StreamState(cmd0, cliIo);
Review Comment:
`CalciteOnlyNodeIntegrationTest#testSetStreaming` covers it. Without this
change a rejected `SET STREAMING ON` leaves `streamState` assigned, and the
following `Connection#close()` hangs.
I rebuilt `ignite-core` with only this change reverted and ran the test via
Maven: it fails with `AssertionError: Connection close hangs after a rejected
SET STREAMING ON`. If it passes for you, please check that the test JVM picks
up the rebuilt `ignite-core` classes rather than an older jar.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/GridQueryProcessor.java:
##########
@@ -198,6 +198,10 @@ public class GridQueryProcessor extends
GridProcessorAdapter {
Pattern.compile("QUERY_ENGINE[\\s]*\\([\\s]*'([a-z0-9]+)'[\\s]*\\)",
CASE_INSENSITIVE);
+ /** Error message for the features that require the H2 query engine when
it is not on the classpath. */
+ private static final String INDEXING_DISABLED_MSG = "Failed to execute
query because indexing is disabled " +
Review Comment:
I'd keep `indexing is disabled`: "indexing" is used as an uncountable noun
here, so it takes no article. The existing message in `checkxModuleEnabled()`
uses the same wording, so the two messages stay consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
