nizhikov commented on code in PR #13668:
URL: https://github.com/apache/ignite/pull/13668#discussion_r4244618645
##########
modules/calcite/pom.xml:
##########
@@ -81,6 +81,13 @@
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
The dependency is required for a Maven run. `IgniteProcessProxy` serializes
the node configuration with XStream in the parent test JVM, and `xstream` is
test-scoped in `ignite-core`, so it is not inherited transitively
(`dependency:tree` for `ignite-calcite` shows it only through this declaration).
With the dependency removed, `CalciteOnlyNodeIntegrationTest` fails in
`beforeTestsStarted`:
```
java.lang.NoClassDefFoundError: com/thoughtworks/xstream/XStream
at
org.apache.ignite.testframework.junits.multijvm.IgniteNodeRunner.storeToFile(IgniteNodeRunner.java:165)
at
org.apache.ignite.testframework.junits.multijvm.IgniteProcessProxy.params(IgniteProcessProxy.java:263)
at
org.apache.ignite.testframework.junits.multijvm.IgniteProcessProxy.<init>(IgniteProcessProxy.java:177)
```
The other modules with multi-JVM tests (`clients`, `compatibility`,
`compress`) declare it the same way. It passes in the IDE because IntelliJ
exposes the test dependencies of `ignite-core` to dependent modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
