Vladsz83 commented on code in PR #13577:
URL: https://github.com/apache/ignite/pull/13577#discussion_r4303378190
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java:
##########
@@ -131,7 +133,7 @@ private IgniteInternalFuture<?>
reduceValidatePartsAndFinish(
return new GridFinishedFuture<>();
try {
- contexts.remove(ctx.req.snapshotName());
+ contexts.remove(ctx.req.snapshotName().toLowerCase(Locale.ROOT));
Review Comment:
Test `doTestConcurrentSnapshotDelete()` is not a final test. It is a tool
routine. Decision to test the sensitivity relies above it, in
`testSnapshotDeleteWhenCheckInProgress()` (for example). It launches one
concurrent snapshot operation with changed name case. Other, with normal case
(in `doTestConcurrentSnapshotDelete()`). This is the idea. On a case
insensitive file system we should not allow such operations running
simultaneously. And this test shows that one operation is blocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
