zstan commented on code in PR #13577:
URL: https://github.com/apache/ignite/pull/13577#discussion_r4303555483
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/AbstractSnapshotSelfTest.java:
##########
@@ -148,6 +153,9 @@ public abstract class AbstractSnapshotSelfTest extends
GridCommonAbstractTest {
protected static final int PAGE_SIZE =
IgniteSystemProperties.getInteger(IGNITE_DEFAULT_DATA_STORAGE_PAGE_SIZE,
DFLT_PAGE_SIZE);
+ /** */
+ protected static boolean caseInsensitiveFs;
Review Comment:
Ok let`s discuss using as example :
```
@Test
public void testConcurrentSnapshotDeleteAndCheckOperations() throws
Exception {
String snapshotName = caseInsensitiveFs ?
SNAPSHOT_NAME.toLowerCase() : SNAPSHOT_NAME;
doConcurrentSnapshotOperationWhenDeletionIsActive(
() -> prepareGridsAndSnapshot(4, 3, 1, false),
() -> snp(grid(2)).checkSnapshot(snapshotName, null).get(),
```
1. You compute snap name according FS sens.
2. You push this name as lambdas into
doConcurrentSnapshotOperationWhenDeletionIsActive
3. doConcurrentSnapshotOperationWhenDeletionIsActive - use SNAPSHOT_NAME
without FS sens
it\`s hard to understand, tell me why we can\`t just simplify it :
A. Remove `caseInsensitiveFs` at all and use snap name only in lower case.
B. Extend (seems it need to be : GridCommandHandlerDeleteSnapshotTest) with
case I mention above it this discussion, wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
