Vladsz83 commented on code in PR #13686:
URL: https://github.com/apache/ignite/pull/13686#discussion_r4346985542
##########
modules/core/src/main/java/org/apache/ignite/internal/management/cache/VerifyBackupPartitionsTask.java:
##########
@@ -494,32 +483,43 @@ private Future<Map<PartitionKey, PartitionHashRecord>>
calculatePartitionHashAsy
if (!part.reserve())
return res;
+ if (!gctx.offheap().stoppageLock().enterBusy()) {
+ part.release();
+
+ return res;
+ }
+
+ boolean gwLocked = false;
+
try {
PartitionUpdateCounter updCntr =
part.dataStore().partUpdateCounter();
PartitionUpdateCounter updateCntrBefore = updCntr == null
? null : updCntr.copy();
+ ignite.context().gateway().readLock();
Review Comment:
> The only question is - whether we should check for cancellation at the
beginning of job execution (using the same check as during page iteration) to
fail fast.
I would say everywhere: before launching the furure/thread/worker, at the
launched job/thread startup, asap in the middle of working, in the cycle. Did
that. But looks duplicating, cluttered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
