Vladsz83 commented on code in PR #13686:
URL: https://github.com/apache/ignite/pull/13686#discussion_r4348469102
##########
modules/core/src/main/java/org/apache/ignite/internal/management/cache/VerifyBackupPartitionsTask.java:
##########
@@ -227,11 +226,8 @@ public VerifyBackupPartitionsJob(CacheIdleVerifyCommandArg
arg) {
long lastProgressLogTs = U.currentTimeMillis();
for (int i = 0; i < partHashCalcFuts.size(); ) {
- if (isCancelled()) {
- cancelFuts(i, partHashCalcFuts);
-
+ if (isCancelled())
Review Comment:
I think, we don't need this method. Let's simplify and remove. 'isCancelled'
is passed to the futures and they have the cancellation exception. There is
enough mess with futures cancellation and processing of the related errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
