vldpyatkov commented on code in PR #13736:
URL: https://github.com/apache/ignite/pull/13736#discussion_r4516322767


##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteStatisticsImpl.java:
##########
@@ -136,4 +153,20 @@ private long getRowCountApproximation() {
 
         return primaryRowCnt;
     }
+
+    /** */
+    private static @Nullable Long localCacheSize(GridCacheContext<?, ?> cctx) 
throws IgniteCheckedException {
+        Collection<ClusterNode> nodes = new 
ArrayList<>(cctx.grid().cluster().forDataNodes(cctx.name()).nodes());
+
+        if (nodes.isEmpty())
+            return null;
+
+        IgniteInternalFuture<Long> fut = cctx.kernalContext().task().execute(
+            new StatisticsCacheSizeTask(cctx.name()),

Review Comment:
   During a rolling upgrade, older nodes cannot load StatisticsCacheSizeTask, 
so row-count refreshes fail. Gate dispatch on an IgniteFeature and use the 
cached estimate until the feature is active.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to