tkalkirill commented on code in PR #13736:
URL: https://github.com/apache/ignite/pull/13736#discussion_r4535106761
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheTableImpl.java:
##########
@@ -81,7 +85,7 @@ public CacheTableImpl(GridKernalContext ctx,
CacheTableDescriptor desc) {
if (statistics != null)
return new IgniteStatisticsImpl(statistics);
- return new IgniteStatisticsImpl(desc);
+ return fallbackStats;
Review Comment:
I’d keep the current initialization for now. The fallback object and its
counter are allocated once per table, and the distributed row count is already
computed on demand. I don’t see enough benefit from deferring those allocations
to justify the extra synchronization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]