rezataroosheh commented on code in PR #13770:
URL: https://github.com/apache/ignite/pull/13770#discussion_r4639688019


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryEntry.java:
##########
@@ -303,6 +303,16 @@ CacheObject oldValue() {
         return oldVal;
     }
 
+    /**
+     * Clears the keep binary flag.
+     *
+     * @param flags Flags.
+     * @return Flags without the keep binary flag.
+     */
+    static byte removeKeepBinary(byte flags) {
+        return (byte)(flags & ~KEEP_BINARY);

Review Comment:
   Thanks, agreed. I removed `removeKeepBinary()`. The transformed entry is now 
created as a new entry, with `(byte)0` flags and its own `keepBinary`, the same 
way `CacheContinuousQueryManager` creates new entries. So its flags are set 
once, in the constructor, and nothing is cleared later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to