rezataroosheh commented on code in PR #13770:
URL: https://github.com/apache/ignite/pull/13770#discussion_r4642004827


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/continuous/CacheContinuousQueryHandler.java:
##########
@@ -1734,16 +1735,22 @@ private CacheContinuousQueryEntry 
transformToEntry(IgniteClosure<CacheEntryEvent
             oldVal = null;
         }
 
+        // The transformer result is not a cache value, so the keep binary 
flag of the cache does not apply to it.
+        // Keep it binary only if the transformer returned a BinaryObject, as 
on the local node.
+        boolean keepBinary = transVal instanceof BinaryObject;

Review Comment:
   Thanks, rebased onto master (incl. IGNITE-29227, #13769) with no conflicts; 
`transformToEntry()` now includes both changes.
   
   For JDK-8180450, I expect minimal impact (also fixed in newer JDKs and 
backported to JDK 21 updates):
   - Runs once per transformed event, only on the transformer node.
   - User classes fail `instanceof` and don't update the affected secondary 
interface cache.
   - Returning a BinaryObject from a transformer is likely the less common 
case, and there, toCacheObject(transVal) right above, already checks instanceof 
CacheObject on the same object.
   
   Only the transformer node knows if the result is a `BinaryObject` or a user 
class, so do you have another approach in mind?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to