shuwenwei commented on PR #162: URL: https://github.com/apache/iotdb-client-go/pull/162#issuecomment-4741278433
`ExecContext` still drops the caller context. `database/iotdb_std.go` passes `ctx` into `std.conn.exec`, but `database/conn_exec.go` accepts that context and then ignores it by calling `session.ExecuteStatement(body)`. That method still delegates to `ExecuteStatementWithContext(context.Background(), sql)`, so `ExecContext` deadlines/cancellation are not propagated to the RPC call. `QueryContext` appears to have been updated correctly: `database/conn.go` now passes `client.WithCtx(ctx)` into `ExecuteQueryStatement`, and `client/session.go` uses that context for `ExecuteQueryStatementV2`, including the reconnect retry path. Please make the exec path mirror this by passing the original `ctx` into `ExecuteStatementWithContext(ctx, body)` or an equivalent context-aware exec method, and add regression coverage for `ExecContext` cancellation/deadline propagation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
