shuwenwei commented on PR #162:
URL: https://github.com/apache/iotdb-client-go/pull/162#issuecomment-4764372220

   Please add a small runnable example or documentation snippet for the new 
`database/sql` driver. This PR adds a new public entry point via 
`sql.Open("iotdb", dsn)`, but currently the usage is only visible from tests.
   
   The example should show at least:
   
   ```go
   import (
       "database/sql"
   
       _ "github.com/apache/iotdb-client-go/v2/database"
   )
   
   db, err := sql.Open("iotdb", 
"iotdb://root:[email protected]:6667?fetch_size=1024&time_zone=UTC&connect_retry_max=5")
   ```
   
   It would also be useful to include one `ExecContext` with bound parameters 
and one `QueryContext` + `Scan` flow, so users can see how parameter binding is 
intended to be used.
   
   Please also state in the example/docs that the current implementation 
constructs `client.NewSessionPool` with the tree SQL dialect and therefore only 
supports IoTDB's tree model for now. It does not currently construct 
`TableSession` / `NewTableSessionPool` or expose a DSN option to select the 
table dialect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to