https://issues.apache.org/bugzilla/show_bug.cgi?id=52040
--- Comment #5 from Milamber <[email protected]> 2011-10-18 23:49:38 UTC --- (In reply to comment #4) > Looks good. > > There should definitely be a menu item to show/hide it, rather than a > property; > maybe the setting should be sticky (as we did with LAF just recently)? Ok, I will add a new menu item. > > Where did the icons come from? >From JMeter code src (directory images) with some changes (convert to png, rename, modified) >From my works with The Gimp (like - + ?, start/stop remote start/stop, cut/copy/paste, etc) > > I think the icon file names should be stored in a property file, as we have > done for the tree icons. ok, I do this. > > I suspect the first thing people are going to want to do is to configure the > buttons - add and remove them and move them around. > > I don't know if that is easy - I expect it would be quite time-consuming to > code. > > But it would be quite easy to add another property to list the icons (and > dividers) in order. So for example one could have: > > new = org/apache/jmeter/images/toolbar/new.png > open = org/apache/jmeter/images/toolbar/open.png > ... > toolbar = new, open, | , etc. Good idea to allow changes on icons order. I can do this too. > > This assumes the properties are in their own file. If we want to share another > file, then we could add a prefix to the property names. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
