https://issues.apache.org/bugzilla/show_bug.cgi?id=52040
--- Comment #10 from Sebb <[email protected]> 2011-10-23 10:31:08 UTC --- I'm not sure it's necessary to have defaults for the icon properties and toolbar. If the icons-toolbar.properties file is not found, then JMeter can display an error box with the details. This would simplify the code quite a bit. However, it would be useful to be able to override the standard properties file. One way to do that is to load it first, and then load the override file (if any). The IconToolbarBean class should probably be immutable; not sure it makes sense to allow any of the fields to be changed. Also, I would probably make it responsible for resolving the ActionNames fields. It could also default the iconPathPressed field to be the same as iconPath, which would simplify the calling code. The code does not affect how tests work, so it can be committed now and tweaked later. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
