rouazana commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526153685
##########
File path:
server/protocols/jmap-rfc-8621-integration-tests/distributed-jmap-rfc-8621-integration-tests/pom.xml
##########
@@ -17,19 +17,17 @@
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
Review comment:
is this white space change mandatory?
##########
File path: server/queue/queue-activemq/pom.xml
##########
@@ -35,9 +35,11 @@
<dependencies>
<!-- Forcing netty-transport version -->
<dependency>
+ <?SORTPOM IGNORE?>
Review comment:
why?
##########
File path: server/pom.xml
##########
@@ -70,9 +70,9 @@
<module>dns-service/dnsservice-library</module>
<module>dns-service/dnsservice-test</module>
- <module>mailet/integration-testing</module>
-
<module>mailet/dkim</module>
+
Review comment:
this blank line does not make sense now
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
this one is trickier because it's not really an internal POM. Maybe we
should replace ${james.groupId} by org.apache.james here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
