jeantil commented on a change in pull request #263:
URL: https://github.com/apache/james-project/pull/263#discussion_r526244131
##########
File path: mailbox/api/pom.xml
##########
@@ -45,10 +49,6 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>${james.groupId}</groupId>
- <artifactId>apache-mime4j-dom</artifactId>
Review comment:
I will make the change.
However I would like to point out
https://maven.apache.org/guides/mini/guide-naming-conventions.html
> groupId uniquely identifies your project across all projects. [...] That
is, if the current project is a multiple module project, it should append a new
identifier to the parent's groupId.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
