This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 6f9e1fbe3f847421c726d8dc7d2a54bc6f1a5c8d Author: Benoit Tellier <[email protected]> AuthorDate: Sun May 16 14:01:54 2021 +0700 [PERFORMANCE] FlagsFactory::createFlags needlessly call the builder This method is responsible of ~2% of total memory allocation as per async-profiler and the builder is the main guilty: Its advanced flags filtering capability, not needed for a copy use case come at a high cost. --- .../apache/james/mailbox/store/mail/model/FlagsFactory.java | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/FlagsFactory.java b/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/FlagsFactory.java index c1d9b15..11adcce 100644 --- a/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/FlagsFactory.java +++ b/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/FlagsFactory.java @@ -30,8 +30,7 @@ import com.google.common.base.Strings; import com.google.common.collect.ImmutableList; public class FlagsFactory { - - private static Flags asFlags(MailboxMessage mailboxMessage, String[] userFlags) { + public static Flags createFlags(MailboxMessage mailboxMessage, String[] userFlags) { final Flags flags = new Flags(); if (mailboxMessage.isAnswered()) { flags.add(Flags.Flag.ANSWERED); @@ -59,13 +58,6 @@ public class FlagsFactory { return flags; } - public static Flags createFlags(MailboxMessage mailboxMessage, String[] userFlags) { - return builder() - .flags(asFlags(mailboxMessage, userFlags)) - .addUserFlags(userFlags) - .build(); - } - public static Builder builder() { return new Builder(); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
