This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 1cfe1f55f29d44c0f9e55c375eecc6a59b23b00f Author: Benoit Tellier <[email protected]> AuthorDate: Sun May 16 22:52:23 2021 +0700 [PERFORMANCE] Use guava Precondition formatter String.format was evaluated on each Version and cost 0.26% of total CPU time budget. --- .../main/java/org/apache/james/PeriodicalHealthChecksConfiguration.java | 2 +- .../src/main/java/org/apache/james/jmap/api/model/Preview.java | 2 +- .../jmap/src/main/java/org/apache/james/jmap/VersionParser.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/container/guice/guice-common/src/main/java/org/apache/james/PeriodicalHealthChecksConfiguration.java b/server/container/guice/guice-common/src/main/java/org/apache/james/PeriodicalHealthChecksConfiguration.java index beac23b..ff124e8 100644 --- a/server/container/guice/guice-common/src/main/java/org/apache/james/PeriodicalHealthChecksConfiguration.java +++ b/server/container/guice/guice-common/src/main/java/org/apache/james/PeriodicalHealthChecksConfiguration.java @@ -54,7 +54,7 @@ public class PeriodicalHealthChecksConfiguration { PeriodicalHealthChecksConfiguration build() { Preconditions.checkArgument(period.compareTo(MINIMAL_HEALTH_CHECK_PERIOD) >= 0, - "'period' must be equal or greater than " + MINIMAL_HEALTH_CHECK_PERIOD.toMillis() + "ms"); + "'period' must be equal or greater than %d ms", MINIMAL_HEALTH_CHECK_PERIOD.toMillis()); return new PeriodicalHealthChecksConfiguration(period); } diff --git a/server/data/data-jmap/src/main/java/org/apache/james/jmap/api/model/Preview.java b/server/data/data-jmap/src/main/java/org/apache/james/jmap/api/model/Preview.java index 42b2428..fd91f50 100644 --- a/server/data/data-jmap/src/main/java/org/apache/james/jmap/api/model/Preview.java +++ b/server/data/data-jmap/src/main/java/org/apache/james/jmap/api/model/Preview.java @@ -103,7 +103,7 @@ public class Preview { Preview(String value) { Preconditions.checkNotNull(value); Preconditions.checkArgument(value.length() <= MAX_LENGTH, - String.format("the preview value '%s' has length longer than %d", value, MAX_LENGTH)); + "the preview value '%s' has length longer than %s", value, MAX_LENGTH); this.value = value; } diff --git a/server/protocols/jmap/src/main/java/org/apache/james/jmap/VersionParser.java b/server/protocols/jmap/src/main/java/org/apache/james/jmap/VersionParser.java index 88603e4..f83237e 100644 --- a/server/protocols/jmap/src/main/java/org/apache/james/jmap/VersionParser.java +++ b/server/protocols/jmap/src/main/java/org/apache/james/jmap/VersionParser.java @@ -45,7 +45,7 @@ public class VersionParser { public VersionParser(Set<Version> supportedVersions, JMAPConfiguration jmapConfiguration) { this.jmapConfiguration = jmapConfiguration; Preconditions.checkArgument(supportedVersions.contains(jmapConfiguration.getDefaultVersion()), - jmapConfiguration + " is not a supported JMAP version"); + "%s is not a supported JMAP version", jmapConfiguration); this.supportedVersions = supportedVersions; } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
